https://bugzilla.redhat.com/show_bug.cgi?id=820544 --- Comment #45 from Jon Ciesla <limburgher@xxxxxxxxx> --- Good: - rpmlint checks return: libguac-client-rdp.src: W: spelling-error Summary(en_US) guacd -> guard The value of this tag appears to be misspelled. Please double-check. libguac-client-rdp.src: W: spelling-error %description -l en_US guacd -> guard The value of this tag appears to be misspelled. Please double-check. 1 packages and 0 specfiles checked; 0 errors, 2 warnings. Ignore. libguac-client-rdp.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libguac-client-rdp.so A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package. Is that really a plugin? The presence of a solib and an include directory with headers makes me think a -devel package might be warranted. - package meets naming guidelines - package meets packaging guidelines - license ( MPLv1.1 or GPLv2+ or LGPLv2+ ) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file Other than my questions about the need for a -devel package, it looks OK. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review