[Bug 825517] Review Request: egtk - The eGTK (elementary GTK) themes for GTK+2, GTK+3, Metacity and Xfwm4

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=825517

--- Comment #3 from Mattia Meneguzzo <mattia.meneguzzo+fedora@xxxxxxxxx> ---
(In reply to comment #2)
> All the four subpackages own the folder %{_datadir}/themes/%{short_name}/
> and contain the same doc files. Currently, there's no base package named
> egtk. I recommend to add a package named egtk-common and let it own the
> aforementioned folder and the doc files.

> %setup -q -c -n %{name}-%{version}
> 
> You may drop "-n %{name}-%{version}" in %setup. Unless you need a different
> name for the build folder, you don't need to add this pattern explicitely.

OK, I'll follow your suggestions.

> Moreover, it is not needed to correct a wrong FSF address. Give the
> developers an appropriate hint and leave the file untouched for the time
> being.

I've already filed a bug report to the eGTK developers about the FSF address
issue: https://bugs.launchpad.net/egtk/+bug/1005780
I'll remove the line  that corrects it from the Spec file.

Thank you.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]