Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: php Alias: php https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226294 ------- Additional Comments From chris.stone@xxxxxxxxx 2007-02-05 20:01 EST ------- Requires: httpd-mmn = %(cat %{_includedir}/httpd/.mmn || echo missing-httpd-devel) php requires httpd-mmn? If it does, then this line is totally ineffective. I have php installed with no httpd-mmn package. Perhaps httpd-devel needs to be added to BR or some kind of build prereq. I was looking at some of the *really* old patches, for example: php-4.3.2-libtool15.patch I don't get this patch, esp since you compile using --with-pic. My ignorance level is pretty amazingly high when it comes to autoconf stuff, but I'm wondering if some of the old patches are still required? I think it makes tons of sense to package php-pear in this package, and send the old php-pear to /dev/null. We can then make a php-pear-PEAR package that basically uses a standard pear class spec file created with fedora-newrpmspec command. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review