[Bug 820544] Review Request: libguac-client-rdp - RDP support for guacd

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=820544

--- Comment #36 from Michael Schwendt <mschwendt@xxxxxxxxx> ---
* _isa in BuildRequires are insane. BuildRequires become the src.rpm's
Requires.


> Requires:       freerdp-plugins < 1.1

Please add a comment to such explicit Requires. You can copy what you added to
the %changelog:
https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires


* The following lead to some head-scratching:

> %post -p /sbin/ldconfig
> 
> %postun -p /sbin/ldconfig

> %files
...
> %{_libdir}/guacamole/%{name}.so
> %{_libdir}/guacamole/%{name}.so.*

So, some shared libs are stored in a private non-default path that is not in
default search path for shared libs. ldconfig is run nevertheless. This
prompted me to take a look at the libguac package. That one creates this
private directory and extends the run-time linker's search path list.

Why? The libguac spec file doesn't answer the question.

The libguac source code dlopen's these modules. They are named
"libguac-client-$(PROTOCOL).so". That's not a naming scheme that asks for
trouble. The libs could be stored in %_libdir without much risk of causing file
conflicts.

A comment in the spec file that %{_libdir}/guacamole/ is provided by libguac
which is an automatic dependency would be nice, too.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]