https://bugzilla.redhat.com/show_bug.cgi?id=818805 --- Comment #9 from Brendan Jones <brendan.jones.it@xxxxxxxxx> --- (In reply to comment #8) > > - I'm confused by the changelog. Where was this spec from originally? You > > need to cull the invalid change log entries. A single changelog entry will > > suffice if the spec was sourced out of Fedora, but even this is not > > necessary. > So am I. But this request is based on old bug 693425 (which I should have > noted in the original request!) The changelog is from there. With this said, > noone would be happier than me if we could drop it. Do you think it's OK, > given this? > Wow! war and peace - yes, drop all of the change log - its not relevant. > > - Rpmlint throws up an error against noarch: > [cut] > > openerp-client.noarch: E: explicit-lib-dependency python-matplotlib > [cut] > This one beats me. I think its a rpmlint error, it somehow thinks anything > named like mathplotlib is a "normal" lib. However, I really need this > Requires:, there is no automatic resolver for python handling this, and I > need the python module. You are right. I did a quick BZ search - this has come up a few times. > > > - use the %{name} macro wherever you can > Done (although note that the guidelines explicitly says this is a matter of > style). True! > > > - I like to see all of the docs/man/bin files defined explicitly in the > > %files section (I find it helps in the review). Its safer, and you can get a > > better picture of the installed RPM. The suffix for man files should be .* > > however > Done Thanks Alec. I'll try and finish this in the next day or so. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review