https://bugzilla.redhat.com/show_bug.cgi?id=818805 --- Comment #6 from Brendan Jones <brendan.jones.it@xxxxxxxxx> --- Hey Alec (apologies - misspelled your name before) Just a few things to clarify before I dig in to this one. - you should prefix your sources with the package name (and version if relevant) - when providing an alternate license file you need to explicitly state where you got it from - I'm confused by the changelog. Where was this spec from originally? You need to cull the invalid change log entries. A single changelog entry will suffice if the spec was sourced out of Fedora, but even this is not necessary. - Rpmlint throws up an error against noarch: rpmlint /home/bsjones/rpmbuild/SRPMS/openerp-client-6.1-1.fc17.src.rpm /home/bsjones/rpmbuild/RPMS/noarch/openerp-client-6.1-1.fc17.noarch.rpm openerp-client.src: W: spelling-error %description -l en_US Gtk -> Gk, Gt, Gt k openerp-client.noarch: E: explicit-lib-dependency python-matplotlib openerp-client.noarch: W: spelling-error %description -l en_US Gtk -> Gk, Gt, Gt k 2 packages and 0 specfiles checked; 1 errors, 2 warnings. - use the %{name} macro wherever you can - I like to see all of the docs/man/bin files defined explicitly in the %files section (I find it helps in the review). Its safer, and you can get a better picture of the installed RPM. The suffix for man files should be .* however Sounds like a lot, but not really. All in pretty good shape -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review