https://bugzilla.redhat.com/show_bug.cgi?id=819480 Pierre-YvesChibon <pingou@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pingou@xxxxxxxxxxxx --- Comment #15 from Pierre-YvesChibon <pingou@xxxxxxxxxxxx> --- Just passing by I had a look at the last spec file (hosted by smooge) Few remarks: - You are using %define while you should not: http://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define - /var/www is not allowed for web-app, see: http://fedoraproject.org/wiki/Packaging/Guidelines#Web_Applications - What is the different between %{name} and %{realname}? - the source0 is not a URL, since upstream's website is down I cannot check, is this a checkout of the sources or just a release candidate which has no direct URL? - The changelog is not correctly formatted (I would expect rpmlint to complain on this) - If the intended target is Fedora and EL6, there are a couple of elements which can go away in the spec (the %clean section, the %defattr, the group) -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review