https://bugzilla.redhat.com/show_bug.cgi?id=830221 --- Comment #9 from Dan Scott <dan@xxxxxxxxxxxxxx> --- (In reply to comment #8) > (In reply to comment #7) > > Hmm. Actually, I think it should be BuildRequires: perl(Module::Build), not > > ExtUtils::MakeMaker for this one. > > Well, you have a choice - but since you're using Makefile.PL and that has > 'use ExtUtils::MakeMaker;' it's perl(ExtUtils::MakeMaker) that you need to > buildrequire. Oops. Per http://fedoraproject.org/wiki/Perl/Tips#Makefile.PL_vs_Build.PL I should be using Build.PL - so I have updated the spec and srpm accordingly. > > One further problem - with the license as "GPL+ or Artistic or BSD", rpmlint > > complains with: > > > > perl-Library-CallNumber-LC.src: W: invalid-license Artistic > > Ah, good catch. Not something to worry too much about - the license is good, > so we could ignore the rpmlint warning. But you can also silence the warning > by forcing it to parse the license better: > License: (GPL+ or Artistic) or BSD Thanks for the tip; I had been trying quotes but in retrospect parentheses are the obvious solution. Note to self: no more working past 1:00 AM! Once again, I have updated http://bzr.coffeecode.net/scratch/perl-Library-CallNumber-LC/ with the new spec & srpm -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review