https://bugzilla.redhat.com/show_bug.cgi?id=829865 --- Comment #3 from Iain Arnell <iarnell@xxxxxxxxx> --- I'm going to wait for MARC-Charset to hit rawhide before formally reviewing this one. In the meantime, though, %attr(0755, - -) %{_bindir}/* is bugging me - it works, but it's inconsistent - should be all commas, or all spaces - I generally prefer commas. But more importantly, it shouldn't be necessary to specify %attr at all in this case - just having %{_bindir}/* in %files ought to be enough (I didn't check - but unless something weird's happening, every other package I've touched automagically ends up with the correct 0755 permissions under %_bindir). And this package also needs to BuildRequire: perl(ExtUtils::MakeMaker). I noticed bug 827801 - perl-MARC-Record is probably something that spot just inherited at some point in the past. It might be an idea to add a comment in the bug that you'd be willing to be co-maintainer and request permissions in pkgdb. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review