[Bug 807472] Review Request: libstoragemgmt - Library for storage array management

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=807472

Tom "spot" Callaway <tcallawa@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|177841 (FE-NEEDSPONSOR)     |
              Flags|                            |fedora-review+

--- Comment #12 from Tom "spot" Callaway <tcallawa@xxxxxxxxxx> ---
== Review ==

Good:

- rpmlint checks return:
libstoragemgmt.src: W: spelling-error %description -l en_US lsmcli -> clime
libstoragemgmt.src: W: spelling-error %description -l en_US lsmd -> LSD
libstoragemgmt.x86_64: W: non-standard-uid /var/run/lsm libstoragemgmt
libstoragemgmt.x86_64: W: non-standard-gid /var/run/lsm libstoragemgmt
libstoragemgmt.x86_64: W: non-standard-uid /var/run/lsm/ipc libstoragemgmt
libstoragemgmt.x86_64: W: non-standard-gid /var/run/lsm/ipc libstoragemgmt
libstoragemgmt.x86_64: W: no-manual-page-for-binary smis_lsmplugin
libstoragemgmt.x86_64: W: no-manual-page-for-binary sim_lsmplugin
libstoragemgmt.x86_64: W: no-manual-page-for-binary smispy_lsmplugin
libstoragemgmt.x86_64: W: no-manual-page-for-binary ontap_lsmplugin
libstoragemgmt-devel.x86_64: W: no-documentation
4 packages and 0 specfiles checked; 0 errors, 11 warnings.

All safe to ignore.

- package meets naming guidelines
- package meets packaging guidelines
- license (LGPLv2+) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
(a4c40334c5bc18872ccac2121a05baa610b5f5d989308f2cb2dae1bd177eccd5)
- package compiles on Fedora 17 (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
- devel package ok
- no .la files
- post/postun ldconfig ok
- devel requires base package n-v-r 

APPROVED. 

Tell me your Fedora Account Username and I will go sponsor you.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]