https://bugzilla.redhat.com/show_bug.cgi?id=830992 --- Comment #6 from Paul Moore <pmoore@xxxxxxxxxx> --- (In reply to comment #4) > This isn't a review, just some comments. Regardless, thanks for the feedback. > I find spec files much easier to read if the fields > are lined up, like this example: > > http://oirase.annexia.org/reviews/whenjobs/whenjobs.spec Noted for future requests, as this is a style issue I'll leave it as-is right now pending the favorite style of the reviewer. > Modern spec files *don't* need: > > * BuildRoot > * %clean > * rm -rf buildroot > * defattr > > All of the above can be removed. Done. > Is the license LGPLv2 or LGPLv2+? LGPLv2. LGPLv2.1 to be specific, but from what I read on the Fedora wiki regarding packaging the LGPLv2 tag applies to both LGPLv2 and LGPLv2.1. > Instead of ./configure + options, use %configure macro. While the libseccomp configure script mimics a few of the autoconf options, it only supports a select few. I think we are better off specifying those few options by hand then risking a change in the %configure macro causing the configure/build to fail for this package. However, if I'm looking at it the wrong way please let me know. > Instead of CFLAGS=..., use 'make %{_smp_mflags}' Noted, but unfortunately the package doesn't build correctly with simultaneous make jobs, e.g. "-j<N>" with "<N>" greater than one. We'll work on this upstream but until we have it sorted we can't use "%{_smp_mflags}"; I tried previously and the results were not good. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review