https://bugzilla.redhat.com/show_bug.cgi?id=790805 Ricardo Rocha <rocha.porto@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ --- Comment #12 from Ricardo Rocha <rocha.porto@xxxxxxxxx> --- (In reply to comment #11) > > So two very minor things (bug reference to upstream for shared-libs-call-exit and comment with gcc error in epel 5). > > Done, https://svnweb.cern.ch/trac/lcgutil/ticket/332 > > > I think the goal was to add a comment explaining why it doesn't build. I would > replace the copy paste from the guidelines with a more detailed description of > the error, which you'll be putting later in the bug anyway. > > I tried to described it with "compilation error internal to gcc on epel 5". > It is a complexe internal compiler error with a direct dependency ( gfal ) > at the linker level. > I think that describing the full complexity of the problem in a ticket > included in the spec file as soon as the review is done would be better. > I can't explain it in a other way without putting a stacktrace :) That's good enough, you can simply add the link and remove the comment later. APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review