Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: vlock https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226530 ruben@xxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|ruben@xxxxxxxxxxxxxxxx |kzak@xxxxxxxxxx CC| |ruben@xxxxxxxxxxxxxxxx Flag|fedora-review? |fedora-review- ------- Additional Comments From ruben@xxxxxxxxxxxxxxxx 2007-02-05 16:14 EST ------- Review for release 23: * RPM name is OK * Source vlock-1.3.tar.gz is the same as upstream * Builds fine in mock * File list looks OK Needs work: * BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) (wiki: PackagingGuidelines#BuildRoot) * Missing SMP flags. If it doesn't build with it, please add a comment (wiki: PackagingGuidelines#parallelmake) * Spec file: some paths are not replaced with RPM macros (wiki: QAChecklist item 7) * The package should contain the text of the license (wiki: Packaging/ReviewGuidelines) Please add COPYING from the source to %doc Notes: * Please consider using {?dist} in the Release tag * Preserve timestamps when installing files Rpmlint is not silent: Source RPM: W: vlock summary-ended-with-dot A program which locks one or more virtual consoles. W: vlock no-url-tag rpmlint of vlock: W: vlock summary-ended-with-dot A program which locks one or more virtual consoles. W: vlock no-url-tag W: vlock conffile-without-noreplace-flag /etc/pam.d/vlock -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review