https://bugzilla.redhat.com/show_bug.cgi?id=824218 --- Comment #2 from Adrian Alves <aalves@xxxxxxxxx> --- (In reply to comment #1) > Did an initial (informal) review of this. Rpmlint output is below: > > polly.src:43: W: macro-in-comment %{buildroot} > polly.src:43: W: macro-in-comment %{_datadir} > polly.src:43: W: macro-in-comment %{name} > polly.src:6: W: mixed-use-of-spaces-and-tabs (spaces: line 6, tab: line 3) > polly.src: W: invalid-url Source0: > https://launchpad.net/polly/1.0/pre-alpha-2/+download/Polly-0.93.4 > (pre-alpha 3.4).tar.gz HTTP Error 404: Not Found > polly.noarch: E: explicit-lib-dependency python-httplib2 > polly.noarch: W: no-documentation > polly.noarch: W: no-manual-page-for-binary polly > polly.noarch: E: invalid-desktopfile /usr/share/applications/polly.desktop > value "GTK;Network" for string list key "Categories" in group "Desktop > Entry" does not have a semicolon (';') as trailing character > > The macro-in-comment stuff can be ignored, I think. However, the line that's > commented was a desktop-file-validate command, and that command would > otherwise cause the build process to fail because the desktop file is > invalid. Because of that.. well, refer to > https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files Desktop > files MUST be formatted properly, and desktop-file-validate (or -install) > must be ran on them. So I think you either need to patch this yourself or > submit a patch upstream. > > The lack of documentation and manual page is also a problem, but.. if there > isn't any upstream, there's not much to do about it, unless you feel like > writing some yourself. > > Looking at the spec file, you are also not taking ownership of a directory > (specifically, the one in %python_sitelib): > > %files > %{_bindir}/polly > %{_datadir}/polly/ > %python_sitelib/polly/* > %python_sitelib/%{upsname}-%{version}.* > %{_datadir}/applications/%{name}.desktop > %{_datadir}/gconf/schemas/%{name}.schemas > %{_datadir}/icons/* > > Something maybe to be concerned about is that the build process is throwing > a *lot* of warnings when installing schemas. I'm not sure if anything can be > done about that, or indeed if it's actually a problem, but I thought I'd > point it out. Here's my rpmbuild output: http://fpaste.org/D8Ho/ Added %%files fixes Spec URL: http://alvesadrian.fedorapeople.org/polly.spec SRPM URL: http://alvesadrian.fedorapeople.org/polly-0.93.4-2.fc16.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review