[Bug 830398] Review Request: lancet - A build tool like Ant or Rake

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=830398

--- Comment #2 from Michel Alexandre Salim <michel+fdr@xxxxxxxxxxxx> ---
Hi Kushal,

- The %{project} macro does not seem to be used anywhere; perhaps you want to
define vendor instead and set it to technomancy? That way you can use it in
both archivename and URL

- The ant dependency should be version 1.7.1 or above, as per the project.clj
and the generated POM file (also, please put a comment for Source1 indicating
that we're generating the POM file using Leiningen (say # generated using
Leiningen 1.7.1, since Leiningen is not packaged yet)

- Probably should use cp -p for %{SOURCE1} else the timestamp will be updated
everytime the package is rebuilt

- In %build section, the 'install' should be outside of the %endif - otherwise
your package won't build on EPEL because you didn't specify a Maven task (both
mvn-jpp and mvn-rpmbuild will be invoked with the install target). Put a \
after mvn-rpmbuild instead to tell it to retrieve the next line

Everything else looks good - please update the package, and I'll try and do
some functional tests against the next dependency in line and see if it works.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]