https://bugzilla.redhat.com/show_bug.cgi?id=819955 --- Comment #2 from Gregor Tätzner <gregor@xxxxxxxxxx> --- pre review: - licence: in addition to GPLv3+: kcm/configwidgets/selectimagebutton.cpp: LGPL (v2.1 or later) kcm/configwidgets/selectimagebutton.h: LGPL (v2.1 or later) - can't access source0, better use this url? http://download.kde.org/unstable/lightdm-kde/src/lightdm-kde-0.1.1.tar.bz2 - mark as config: %{_sysconfdir}/dbus-1/system.d/org.kde.kcontrol.kcmlightdm.conf - missing doc: COPYING, NEWS - use %name macro at least in source0 - validate greeter/lightdm-kde-greeter.desktop (it's ok)? thanks :) -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review