https://bugzilla.redhat.com/show_bug.cgi?id=830053 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags| |fedora-review+ --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> --- Review: + koji build f18 -> http://koji.fedoraproject.org/koji/taskinfo?taskID=4147698 + rpmlint on rpms gave ibus-libpinyin.x86_64: E: incorrect-fsf-address /usr/share/ibus-libpinyin/setup/version.py ibus-libpinyin.x86_64: E: incorrect-fsf-address /usr/libexec/ibus-setup-libpinyin ibus-libpinyin.x86_64: E: incorrect-fsf-address /usr/share/ibus-libpinyin/setup/main2.py 2 packages and 0 specfiles checked; 3 errors, 0 warnings. ==> You can inform upstream to update fsf address + source verified with upstream as (sha1sum) 2fbc315711df1472cccd4849b3438d14faa65f94 ibus-libpinyin-1.4.0.tar.gz 2fbc315711df1472cccd4849b3438d14faa65f94 ../SOURCES/ibus-libpinyin-1.4.0.tar.gz + Package: ibus-libpinyin-1.4.0-1.fc18.x86_64 Provides: ibus-libpinyin = 1.4.0-1.fc18 ibus-libpinyin(x86-64) = 1.4.0-1.fc18 Requires: /bin/sh libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3.4)(64bit) libc.so.6(GLIBC_2.4)(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libibus-1.0.so.5()(64bit) liblua-5.1.so()(64bit) libm.so.6()(64bit) libopencc.so.1()(64bit) libpinyin.so.0()(64bit) libpinyin.so.0(LIBPINYIN)(64bit) libpthread.so.0()(64bit) libpthread.so.0(GLIBC_2.2.5)(64bit) libsqlite3.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(GLIBCXX_3.4)(64bit) libstdc++.so.6(GLIBCXX_3.4.11)(64bit) libstdc++.so.6(GLIBCXX_3.4.14)(64bit) libuuid.so.1()(64bit) rtld(GNU_HASH) suggestions: 1) Try not to hardcode the version in requires and buildrequires. Only if there is strict dependency of any version then only mention that in spec. 2) If this package is not for RHEL then you can remove following a)removal of buildroot in %install b) %clean section c) %defattr(-,root,root,-) 3) A new macro has been introduced in latest changes in packaging guidelines. See http://fedoraproject.org/wiki/Packaging:Guidelines#Why_the_.25makeinstall_macro_should_not_be_used Use -> %make_install INSTALL="install -p" above will also preserve timestamps. APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review