https://bugzilla.redhat.com/show_bug.cgi?id=829860 --- Comment #5 from Dan Scott <dan@xxxxxxxxxxxxxx> --- Iain: thanks so much for your detailed review comments! I do hope that Evergreen (http://evergreen-ils.org) will be useful to the community of Evergreen; you can always pass my contact info on for help if that comes to pass. I've revised the package SPEC and SRPM according to your advice (and added a line to the ChangeLog crediting you for your feedback): Spec URL: http://bzr.coffeecode.net/scratch/perl-MARC-Charset/perl-MARC-Charset.spec SRPM URL: http://bzr.coffeecode.net/scratch/perl-MARC-Charset/perl-MARC-Charset-1.33-1.fc17.src.rpm In retrospect, pointing at %{perl_vendorarch} seems like the obvious way to solve the arch-specific problem. Thanks for your other suggestions, as well, that in some cases helped turn a statement of fact ("Fedora does not require the presence of the BuildRoot tag") into a prescriptive guideline ("Do not include the BuildRoot tag.") or flagged an archaic practice (not using DESTDIR for the install argument). I have also delved back into a number of the packaging documents to increase my familiarity with the guidelines, which were pretty overwhelming on my first pass through them. I plan on reviewing other package submissions, but wanted some reassurance that I was on the right track and wouldn't be misdirecting other would-be packages. Thanks so much for your generous donation of time to help me out! -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review