https://bugzilla.redhat.com/show_bug.cgi?id=830221 Iain Arnell <iarnell@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |iarnell@xxxxxxxxx Depends On| |829860 Assignee|nobody@xxxxxxxxxxxxxxxxx |iarnell@xxxxxxxxx Flags| |fedora-review? --- Comment #1 from Iain Arnell <iarnell@xxxxxxxxx> --- This looks to be a nice clean package with no major blockers - just a couple of minor nits: you should explicitly BuildRequire: perl(Math::BigInt) perl(strict) perl(warnings) Use DESTDIR instead of PERL_INSTALL_ROOT in %install section. You don't need to explicitly Require: perl(Math::BigInt) - rpm detects this dependency automatically. Fix the nits and I'll approve once we've got you sponsored in bug 829860. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review