[Bug 823056] Review Request: php-symfony2-Locale - Symfony2 Locale Component

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=823056

Remi Collet <fedora@xxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |fedora@xxxxxxxxxxxxxxxxx
              Flags|                            |fedora-review?

--- Comment #5 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> ---
This package seems broken.

Until version 2.0.14 all ".res" file were installed as "php"
Since version 2.0.15 they are installed as "doc"

In code (Symfony/Component/Locale/Locale.php) the have
$bundle = \ResourceBundle::create($locale, __DIR__.'/Resources/data/region');

So, file will not be found.

This, of course, need to be reported upstream and, at least fixed in
package.xml for the review

All this "locale" %files should be tag with "%lang(xx)"


----
Out of the scope of this review:

I personally think this files should be installed as "data" but this will
requires some changes in the code ()

For example (taken from Date_Holidays)
$data_dir = "@DATA-DIR@";
if ($data_dir == '@'.'DATA-DIR'.'@') {
  // run from source dir
  $data_dir = dirname(__FILE__)."xxxxxxx"; 
} else {
  // run from install dir
  $data_dir .= "xxxxxx";
}

And, in package.xml, when needed
    <tasks:replace from="@DATA-DIR@" to="data_dir" type="pear-config" />

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]