Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pythoncad - PythonCAD scriptable CAD package https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225119 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-02-05 12:50 EST ------- Created an attachment (id=147379) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=147379&action=view) Mock build log of PythonCAD-0.1.35-2.fc7 Mock build log of PythonCAD-0.1.35-2 on FC-devel i386. Dependency changed during python 2.4 -> 2.5 and this package needs "BuildRequires: python-devel". Then... * Directory structure ------------------------------------------- %config(noreplace) %{_sysconfdir}/pythoncad/prefs.py* ------------------------------------------- - Well, the files under /etc are configuration files and generally no binaries are permitted (for this package .pyc or .pyo file) prefs.py should be moved to normally %{_datadir}/%{name}. This movement also requires some other modification on files included in PythonCAD. * File entry ---------------------------------- %{_bindir}/gtkpycad* ---------------------------------- - This asterisk is no longer needed. * Desktop file ----------------------------------- [Desktop Entry] Name=PyCAD Comment=PythonCAD Icon=/usr/share/pixmaps/gtkpycad.png Exec=/usr/bin/gtkpycad.py Terminal=false Type=Application Encoding=UTF-8 X-Desktop-File-Install-Version=0.12 Categories=Office;Graphics;Application;Utility;X-Red-Hat-Base; ---------------------------------------- - Exec entry is wrong.. - For icon entry, "Icon=gtkpycad.png" is preferred. - Both categories "Application" "X-Red-Hat-Base" are deprecated and should be removed. * Requires - Please check python related dependency. For example, Interface/Gtk/gtktext.py includes the line: ---------------------------------------- import pango ---------------------------------------- This means this package needs "pygtk2" for Requires. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review