https://bugzilla.redhat.com/show_bug.cgi?id=827649 --- Comment #3 from Adrian Alves <aalves@xxxxxxxxx> --- (In reply to comment #1) > Just some quick comments: > > - You are mixing variable style ($RPM_BUILD_ROOT) and macro style > (%{buildroot}). > - There is a typo in the summary. > - Using macros in Source0 would make your life easier when updating the > package later. > - The %clean section is no longer needed. The build root is clean in the > %install section automatically too. > https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean > - In the description at the end a period is missing. Thanks for ur help I made all the fixes that u suggest and even tested with rpmlint Spec URL: http://alvesadrian.fedorapeople.org/supercat.spec SRPM URL: http://alvesadrian.fedorapeople.org/supercat-0.5.5-2.fc16.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review