Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: IceWM - Lightweight Window Manager. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222521 ------- Additional Comments From pertusus@xxxxxxx 2007-02-05 11:53 EST ------- (In reply to comment #42) > I'm a KISS kind of guy. If it's all the same to you, I rather keep the startup > file as a patch/source. A HERE-doc isn't less KISS. I would have preferred the startup script in the main package and not in the xdgmenu subpackage, but I won't make it a blocker. Remaining issues: * Add a dot at the end of the %description gnome * in xdgmenu the %files section could be %defattr(-,root,root,-) %{_bindir}/icewm-xdg-menu* %{_datadir}/icewm/startup with an install command for startup script of %{__install} -p -m 755 %{SOURCE4} $RPM_BUILD_ROOT%{_datadir}/icewm/startup * sub packages should depend on a full versioned main package, like Requires: icewm = %{version}-%{release} -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review