https://bugzilla.redhat.com/show_bug.cgi?id=829809 William Cohen <wcohen@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wcohen@xxxxxxxxxx Flags| |needinfo? --- Comment #2 from William Cohen <wcohen@xxxxxxxxxx> --- Some comments on the rpm rpmlint ../SRPMS/python-svg-0.2.1-1.fc18.src.rpm ../RPMS/noarch/python-svg-0.2.1-1.fc18.noarch.rpm python-svg.src: W: spelling-error %description -l en_US pySVG -> Pepys python-svg.src: W: invalid-url Source0: pysvg-0.2.1.zip python-svg.noarch: W: spelling-error %description -l en_US pySVG -> Pepys 2 packages and 0 specfiles checked; 0 errors, 3 warnings. Make the Source0: point at the location to get pysvg-0.2.1.zip file http://pysvg.googlecode.com/files/pysvg-0.2.1.zip Where did the Source1: pysvg-license.txt file come from? The licensing isn't clear for pysvg http://code.google.com/p/pysvg/issues/detail?id=6 It would be very good if the sources had a clear license file in the sources. http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Clarification SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [25] Source rpm seems to violate this MUST: MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc.[4] Should be able to remove the %clean section Also can get rid of the "rm -rf $RPM_BUILD_ROOT" in %install -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review