[Bug 825489] Review Request: opencsg - Library for Constructive Solid Geometry using OpenGL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=825489

--- Comment #6 from Greg Jurman <gdj2214@xxxxxxx> ---
> Don't use the rm macro. Just use "rm -rf" like you did below.
Fixed

> You don't need to rm the buildroot in the install section and you don't need to define defattr in the files sections either.
Fixed

> Use -p on cp to preserve the timestamp of the header file. But you could also consider to correct src.pro. In this case you should be able to drop most of your commands from the install section.
Added -p to cp. Will look into fixing src.pro.

>It seems to me, libGLEW is not linked to the libraries. Am I wrong?
It is used in the example application.

>Please ship license.txt via %doc as well.
Fixed

Updated Files:
Spec URL: https://raw.github.com/gregjurman/opencsg-spec/master/opencsg.spec
SRPM URL:
https://github.com/gregjurman/opencsg-spec/raw/master/opencsg-1.3.2-3.fc17.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]