https://bugzilla.redhat.com/show_bug.cgi?id=804666 --- Comment #6 from Jon Ciesla <limburgher@xxxxxxxxx> --- Good: - rpmlint checks return: The spelling errors are no problem, but rpm-build-root and devel-file-in-non-devel-package should be fixed. Move the libpfm.so to -devel, and remove $RPM_BUILD_ROOT from line 70. Still builds with this change. - package meets naming guidelines - package meets packaging guidelines - license ( MIT ) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream FIX package compiles on devel (x86_64) Builds fine on f17, but dies in mock for rawhide. End of relevant log section: cc -g -Wall -Werror -I. -I/builddir/build/BUILD/libpfm-4.2.0/perf_examples/../include -DCONFIG_PFMLIB_DEBUG -DCONFIG_PFMLIB_OS_LINUX -I. -D_GNU_SOURCE -pthread -c notify_self.c notify_self.c:50:29: error: 'struct siginfo' declared inside parameter list [-Werror] notify_self.c:50:29: error: its scope is only this definition or declaration, which is probably not what you want [-Werror] notify_self.c: In function 'sigio_handler': notify_self.c:59:10: error: dereferencing pointer to incomplete type notify_self.c:67:10: error: dereferencing pointer to incomplete type notify_self.c:70:39: error: dereferencing pointer to incomplete type notify_self.c:72:49: error: dereferencing pointer to incomplete type notify_self.c:93:18: error: dereferencing pointer to incomplete type notify_self.c: In function 'main': notify_self.c:133:39: error: assignment from incompatible pointer type [-Werror] cc1: all warnings being treated as errors - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file - devel package ok - no .la files - post/postun ldconfig ok - devel requires base package n-v-r So it's the two things above. Also I was wondering, do you really need to ship the static libs, since it builds a solib? Does papi or something else need it? -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review