Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: basesystem https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225608 roozbeh@xxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |pknirsch@xxxxxxxxxx Flag| |fedora-review- ------- Additional Comments From roozbeh@xxxxxxxxxxxxx 2007-02-05 10:39 EST ------- rpmlint output: SRPM: W: basesystem summary-ended-with-dot The skeleton package which defines a simple Red Hat Linux system. W: basesystem invalid-license public domain W: basesystem no-url-tag W: basesystem prereq-use setup filesystem W: basesystem hardcoded-path-in-buildroot-tag /var/tmp/basesystem-root E: basesystem no-cleaning-of-buildroot %install E: basesystem no-cleaning-of-buildroot %clean W: basesystem no-%prep-section W: basesystem no-%build-section W: basesystem no-%install-section W: basesystem no-%clean-section RPM: W: basesystem summary-ended-with-dot The skeleton package which defines a simple Red Hat Linux system. W: basesystem invalid-license public domain W: basesystem no-url-tag W: basesystem no-documentation Random issues: * Change "Red Hat Linux" to "Fedora" (both in summary and description). blocker. * What is the version "8.0"?! I can't say this follows naming guidelines. * Make release integer (6?). * Using Prereq is bad. Change to Requires. blocker. * Capitalize "Public Domain". * Change BuildRoot to %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) * description says this should be the first package installed on a system, but the package Prereq's "setup" and "filesystem". Confusing. * Add empty sections for %prep, %build, %install, and %clean. blocker. * Theoretically, the %files section should contain a %defattr line. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review