https://bugzilla.redhat.com/show_bug.cgi?id=829119 --- Comment #2 from Ralph Bean <rbean@xxxxxxxxxx> --- ** MUST ** Do you intend to support EPEL5? If not the "rm -rf $RPM_BUILD_ROOT" at the beginning of %install is unnecessary and should be removed. Is there a reason you're not using the pypi distributed tarball? http://pypi.python.org/pypi/vcstools If you intend to use the hg snapshot over the pypi distribution for a deliberate reason, you should indicate the hg changeset hash in the version number. ** SHOULD ** Please notify upstream and ask them to include the full text of the license with their distribution; I couldn't find it in the source tree. Once they include it, it should be included in the %doc macro.j -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review