[Bug 817622] Re-Review Request: libkgapi - Library to access to Google services

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=817622

Gregor Tätzner <gregor@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gregor@xxxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |gregor@xxxxxxxxxx

--- Comment #6 from Gregor Tätzner <gregor@xxxxxxxxxx> ---
(In reply to comment #5)
> Do you think I should remove comments in spec file?
Are you considering using git snapshots for your package in the near future? If
not, then remove them.

You should drop rm -rf %{buildroot} at %install

imho this project url is better: http://projects.kde.org/libkgoogle

oh, and can you align your indentations please. It looks messy :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]