[Bug 828879] Review Request: system-storage-manager - A single tool to manage your storage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=828879

Fabian Affolter <mail@xxxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mail@xxxxxxxxxxxxxxxxxx

--- Comment #1 from Fabian Affolter <mail@xxxxxxxxxxxxxxxxxx> ---
Just some quick comments:

- Please check the guidelines for the python macros
  https://fedoraproject.org/wiki/Packaging:Python#Macros
- A simple comment in %build (like #nothing to build) to calm rpmlint down is
sufficient.
- Python 2.7.x was introduced around F14/F15. Maybe drop the Python 2.6.x
stuff.
- %clean and BuildRoot tag can be dropped if the packages is not going to
EPEL5. If it's going to EPEL5 then you have to add %defattr to the %files
section.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]