https://bugzilla.redhat.com/show_bug.cgi?id=739016 Michel Alexandre Salim <michel+fdr@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #5 from Michel Alexandre Salim <michel+fdr@xxxxxxxxxxxx> --- I normally remind myself which part is only relevant to which distro release by using, e.g. %if 0%{?el5} ... %endif and %if 0%{?rhel} ... %endif (the Group field can be dropped outside of RHEL as well - new rpmdev-newspec templates omit them for RPM >= 4.8 or so) -- but that's a personal preference (and I find reviewers don't hassle me for having deprecated definitions if I mark them that way :) You can drop the %defattr even on RHEL 5 too -- it has RPM 4.4. But you can do that when importing the package -- APPROVED -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review