https://bugzilla.redhat.com/show_bug.cgi?id=823337 Vít Ondruch <vondruch@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vondruch@xxxxxxxxxx --- Comment #6 from Vít Ondruch <vondruch@xxxxxxxxxx> --- (In reply to comment #5) > Why are you building before you patch? (and not in the %build section?) > %prep needs a good lookover anyway - checkout this: > https://fedoraproject.org/wiki/Packaging/Ruby#.25prep 99% of gems are fine with the %prep section as used by Jonas. The %prep section as suggested by guidelines is not mandatory IMO. Jonas, I have 2 notes: * Could you please unpack the test suite in the %check section, something like rubybem-hike [1] for example? Also running in .%{gem_instdir} is preferable (although it has definitely some downsides). This will prevent possible pollution of the packaged gem. * I typically suggest to exclude the %{gem_cache}. [1] http://pkgs.fedoraproject.org/gitweb/?p=rubygem-hike.git;a=blob;f=rubygem-hike.spec;h=68f3affe56da17bbf72226da7030a2031c078150;hb=HEAD -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review