https://bugzilla.redhat.com/show_bug.cgi?id=822730 Sergio Monteiro Basto <sergio@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sergio@xxxxxxxxxx --- Comment #8 from Sergio Monteiro Basto <sergio@xxxxxxxxxx> --- (In reply to comment #4) > I know i used the spec from dag Good, my diff is also based from dag > I already said that. But i made the changes > to make it works on fedora did u try it or make any review about it? 1 - at least, put things in %install not in %build ( and leave %build empty) 2 - %{__rm} -rf %{buildroot} is deprecated look at my diff, IMHO looks much more clean, I don't see the point of enumerate man and don't use %doc %{_mandir}/man8/*.8* -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review