Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Magic - A very capable VLSI layout tool https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223591 ------- Additional Comments From panemade@xxxxxxxxx 2007-02-05 07:02 EST ------- (In reply to comment #10) > Created an attachment (id=147302) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=147302&action=view) [edit] > Mock build log of magic-7.4.33-4.fc7 > > Mock build log of magic-7.4.33-4 on FC-devel i386. > > * Currently I cannot figure out why mockbuild log says: > ----------------------------------------------- > BLT: no > > Tcl/Tk magic uses the BLT package to create a tree diagram > of the cell hierarchy in a design. Without it, this option > is unavailable. Consider installing the BLT package. > ----------------------------------------------- > mock build showed me this as Yes > * icon cache updating > ----------------------------------------------- > %post > touch --no-create %{_datadir}/icons/hicolor || : > %{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || : > > %postun > touch --no-create %{_datadir}/icons/hicolor || : > %{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || : > -------------------------------------------------- > - I don't think this is needed because this package > installs no icon image files into the directory. as per given on http://fedoraproject.org/wiki/Packaging/ScriptletSnippets, I could not find any files being installed in %{_datadir}/icons. So you can remove this scriptlets. > > * rpmlint > says.. > -------------------------------------------------- > W: magic hidden-file-or-dir /usr/lib/magic/sys/.magicrc > E: magic script-without-shebang /usr/lib/magic/tcl/console.tcl > -------------------------------------------------- > * What is the formar file? > * I think the latter is surely the issue. I think you have given some explanation for that in comment #1 > > * Please consider to make the log of compile more > precise, not just telling us: > -------------------------------------------------- > --- compiling cmwind/CMWcmmnds.o > --- compiling cmwind/CMWundo.o > --- compiling cmwind/CMWrgbhsv.o > --- linking libcmwind.o > -------------------------------------------------- > I cannot find what is actually done here. Looks like make command is not providing that info. > > * Documentation > - main package contains the files under > /usr/lib/magic/doc, which seem to be the same files > in -doc file. yes. i found them similar from -doc to main package. any reason for adding doc files again in main package also? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review