Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: gnuplot https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225849 ------- Additional Comments From pertusus@xxxxxxx 2007-02-05 06:43 EST ------- * BuildRoot isn't the right one * Wouldn't it be a good idea to add directories holding truetype fonts located in %{_datatdir}/fonts to the gnuplot-4.0.0-refers_to.patch patch? * A suggestion: depend on the font packages. It has pros and cons. * unuseful requires: Requires: libpng * I don't like the License tag. It appears not to be free software as it is now, although it is. Maybe it would be better to have something like License: Gnuplot And in a comment say something along # changes must be distributed as patches * RPM_OPT_FLAGS is unuseful on make command line, and %{?_smp_mflags} is missing. I tested that replacing with make %{?_smp_mflags} seems right. Is PATH=$RPM_BUILD_DIR/gnuplot-%{version}:$PATH really needed? * The %post scriptlet should be run everytime not only at install time * A suggestion: in %{files} use wildcard to handle different compression or no compression: %{_mandir}/man1/gnuplot.1* %{_infodir}/gnuplot.info* * The doc in psdoc isn't generated rightly. I suggested cd to the directory and make ps_symbols.ps ps_fontfile_doc.pdf Then distribute only ps_fontfile_doc.pdf ps_guide.ps ps_symbols.ps ps_file.doc It implies a BuildRequires on latex for pdflatex -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review