https://bugzilla.redhat.com/show_bug.cgi?id=808884 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #7 from Petr Pisar <ppisar@xxxxxxxxxx> --- Spec file changes: --- perl-Data-Clone.spec.old 2012-04-01 15:45:49.000000000 +0200 +++ perl-Data-Clone.spec 2012-06-02 16:13:07.000000000 +0200 @@ -1,21 +1,23 @@ Name: perl-Data-Clone Version: 0.003 -Release: 1%{?dist} +Release: 2%{?dist} Summary: Polymorphic data cloning License: GPL+ or Artistic Group: Development/Libraries URL: http://search.cpan.org/dist/Data-Clone/ Source0: http://www.cpan.org/authors/id/G/GF/GFUJI/Data-Clone-%{version}.tar.gz -BuildRequires: perl >= 1:5.8.1 +BuildRequires: perl(constant) BuildRequires: perl(Data::Dumper) BuildRequires: perl(Devel::PPPort) >= 3.19 -BuildRequires: perl(ExtUtils::MakeMaker) BuildRequires: perl(ExtUtils::ParseXS) >= 2.21 +BuildRequires: perl(inc::Module::Install) +BuildRequires: perl(Module::Install::AuthorTests) BuildRequires: perl(parent) BuildRequires: perl(Scalar::Util) BuildRequires: perl(Test::LeakTrace) BuildRequires: perl(Test::More) BuildRequires: perl(Test::Requires) +BuildRequires: perl(threads) BuildRequires: perl(Tie::Array) BuildRequires: perl(Tie::Hash) BuildRequires: perl(Time::HiRes) @@ -59,5 +61,9 @@ %{_mandir}/man3/* %changelog +* Fri Jun 01 2012 Iain Arnell <iarnell@xxxxxxxxx> 0.003-2 +- BuildRequire inc::Module::Install, not EU::MM +- additional BuildRequires for tests + * Sun Apr 01 2012 Iain Arnell <iarnell@xxxxxxxxx> 0.003-1 - Specfile autogenerated by cpanspec 1.79. > FIX: Build-require `perl(inc::Module::Install)' (Makefile.PL:3) instead of > `perl(ExtUtils::MakeMaker)'. -BuildRequires: perl(ExtUtils::MakeMaker) BuildRequires: perl(ExtUtils::ParseXS) >= 2.21 +BuildRequires: perl(inc::Module::Install) +BuildRequires: perl(Module::Install::AuthorTests) Ok. > TODO: Consider removing bundled Perl modules under inc/ and build-requiring > appropriate modules like Module::Install::AuthorTests. Otherwise you need explicitly > build-require all dependencies of inc/* code. > FIX: Build-require modules used by code under inc/ (ExtUtils::Manifest, YAML::Tiny, > etc.). I really recommend unbundling inc/*. Well, you build-require the inc::Module::Install and Module::Install::AuthorTests now, but because you left the bundled files in inc, they are still used instead of the system ones: # strace -eopen perl Makefile.PL 2>&1 |grep Install open("/usr/share/perl5/vendor_perl/inc/Module/Install.pm", O_RDONLY) = 4 open("inc/Module/Install.pm", O_RDONLY) = 4 open("inc/Module/Install/XSUtil.pm", O_RDONLY) = 4 open("inc/Module/Install/Base.pm", O_RDONLY) = 5 open("inc/Module/Install/AuthorTests.pm", O_RDONLY) = 4 open("inc/Module/Install/Repository.pm", O_RDONLY) = 4 open("inc/Module/Install/WriteAll.pm", O_RDONLY) = 4 open("inc/Module/Install/Metadata.pm", O_RDONLY) = 4 open("inc/Module/Install/Can.pm", O_RDONLY) = 4 open("inc/Module/Install/Makefile.pm", O_RDONLY) = 4 TODO: That means you still need to build-require all modules used from those files. I believe you can see the reasoning for removing the inc directory now and you will do it. > TODO: Build-require `perl(threads)' for optional tests (t/10_threads.t:4). +BuildRequires: perl(threads) Ok. > TODO: Build-require `perl(constant)' which can dual-live in the future > (t/10_threads.t:4). +BuildRequires: perl(constant) Ok. All tests pass. Ok. > TODO: Do not explicitly run-require auto-discovered perl(Exporter). $ rpm -q --requires -p ../RPMS/x86_64/perl-Data-Clone-0.003-2.fc18.x86_64.rpm |sort |uniq -c 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.11)(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 perl >= 0:5.008_001 2 perl(Exporter) 1 perl(:MODULE_COMPAT_5.14.2) 1 perl(parent) 1 perl(strict) 1 perl(XSLoader) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 1 rtld(GNU_HASH) Not addressed. Ok. Package build is F18 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4124880). Ok. Please consider purging the inc directory before building this package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review