[Bug 827664] Review Request: zukini - Themes for GTK+2, GTK+3, Metacity and GNOME Shell

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=827664

--- Comment #8 from Mattia Meneguzzo <mattia.meneguzzo+fedora@xxxxxxxxx> ---
(In reply to comment #7)
> All previously raised issues addressed -- just one more thing (related to
> the comment Artyom made in the Zukitwo review): there are references to
> Ubuntu-specific things in both Zukini and Zukitwo that needs to be fixed:
> 
> 
> ➜  themes  grep -r "font-family: Ubuntu" Zuki*
> Zukini/gnome-shell/gnome-shell.css:	font-family: Ubuntu, Droid Sans,
> sans-serif;
> Zukitwo-Shell/gnome-shell/gnome-shell.css:	font-family: Ubuntu, Droid Sans,
> sans-serif;
> ➜  themes  grep -r unity Zuki*                
> Zukini/gtk-3.0/gtk.css:@import url("apps/unity.css");
> Zukitwo/gtk-3.0/gtk.css:@import url("apps/unity.css");
> Zukitwo-Dark/gtk-3.0/gtk.css:@import url("apps/unity.css");
> 
> The font reference is not so bad as it'd fall back to the next font in line
> (either Droid Sans -- available but not installed by default, or sans-serif)
> but the unity reference causes a warning to be outputted to the console
> every time a GTK3 app is started:
> 
> (evince:6289): Gtk-WARNING **: Theme parsing error: gtk.css:60:30: Failed to
> import: Error opening file: No such file or directory
> 
> So it's probably best to carry a patch that when applied would remove that
> line (in both themes), and apply that patch during the %setup phase.

Thanks for your suggestions.
The best solution for me would be removing "Ubuntu" from "font-family" (through
a patch, as you suggest) and adding "google-droid-fonts" as a requirement.
Do you agree?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]