https://bugzilla.redhat.com/show_bug.cgi?id=827730 --- Comment #3 from Kevin Fenzi <kevin@xxxxxxxxx> --- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License OK - License field in spec matches See below - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 85b5ad87cb14d4d64f96050a12118d95 Automattic-trac-code-comments-plugin-v1.0.1-52-gb260714.tar.gz 85b5ad87cb14d4d64f96050a12118d95 Automattic-trac-code-comments-plugin-v1.0.1-52-gb260714.tar.gz.new OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Doc subpackage needed/used. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have sane scriptlets. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. The release seems a bit off here. See http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_packages for more info. If this is a prerelease of 1.2.0, I'd suggest: 0.1.alpha2 or 0.1.20120601gitb260714 (if there's no tag/release of alpha2) 2. Might ask upstream to include copies of the licenses it's under. (non blocker) 3. rpmlint says: trac-code-comments-plugin.src: W: invalid-url Source0: Automattic-trac-code-comments-plugin-v1.0.1-52-gb260714.tar.gz 2 packages and 0 specfiles checked; 0 errors, 1 warnings. Which can be ignored. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review