https://bugzilla.redhat.com/show_bug.cgi?id=819893 Erik van Pienbroek <erik-fedora@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |erik-fedora@xxxxxxxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |erik-fedora@xxxxxxxxxxxxxxx Flags| |fedora-review+ --- Comment #2 from Erik van Pienbroek <erik-fedora@xxxxxxxxxxxxxxx> --- $ rpmlint mingw-gsl.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint mingw-gsl-1.15-1.fc17.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint mingw32-gsl-1.15-1.fc17.noarch.rpm mingw32-gsl-static-1.15-1.fc17.noarch.rpm mingw64-gsl-1.15-1.fc17.noarch.rpm mingw64-gsl-static-1.15-1.fc17.noarch.rpm mingw32-gsl.noarch: E: incorrect-fsf-address /usr/i686-w64-mingw32/sys-root/mingw/include/gsl/gsl_sf_mathieu.h mingw32-gsl.noarch: E: incorrect-fsf-address /usr/i686-w64-mingw32/sys-root/mingw/include/gsl/gsl_cdf.h mingw32-gsl-static.noarch: W: no-documentation mingw64-gsl.noarch: E: incorrect-fsf-address /usr/x86_64-w64-mingw32/sys-root/mingw/include/gsl/gsl_sf_mathieu.h mingw64-gsl.noarch: E: incorrect-fsf-address /usr/x86_64-w64-mingw32/sys-root/mingw/include/gsl/gsl_cdf.h mingw64-gsl-static.noarch: W: no-documentation 4 packages and 0 specfiles checked; 4 errors, 2 warnings. $ rpm --query --requires mingw32-gsl /bin/sh mingw32(kernel32.dll) mingw32(libgsl-0.dll) mingw32(libgslcblas-0.dll) mingw32(msvcrt.dll) mingw32(user32.dll) mingw32-crt mingw32-filesystem >= 83 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsXz) <= 5.2-1 $ rpm --query --requires mingw64-gsl /bin/sh mingw64(kernel32.dll) mingw64(libgsl-0.dll) mingw64(libgslcblas-0.dll) mingw64(msvcrt.dll) mingw64(user32.dll) mingw64-crt mingw64-filesystem >= 83 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsXz) <= 5.2-1 $ rpm --query --provides mingw32-gsl mingw32(libgsl-0.dll) mingw32(libgslcblas-0.dll) mingw32-gsl = 1.15-1.fc17 $ rpm --query --provides mingw64-gsl mingw64(libgsl-0.dll) mingw64(libgslcblas-0.dll) mingw64-gsl = 1.15-1.fc17 $ wget --quiet ftp://ftp.gnu.org/gnu/gsl/gsl-1.15.tar.gz -O - | md5sum 494ffefd90eef4ada678c306bab4030b - $ md5sum gsl-1.15.tar.gz 494ffefd90eef4ada678c306bab4030b gsl-1.15.tar.gz + OK ! Needs to be looked into / Not applicable [!] Compliant with generic Fedora Packaging Guidelines [+] Source package name is prefixed with 'mingw-' [+] Spec file starts with %{?mingw_package_header} [+] BuildRequires: mingw32-filesystem >= 95 is in the .spec file [+] BuildRequires: mingw64-filesystem >= 95 is in the .spec file [+] Spec file contains %package sections for both mingw32 and mingw64 packages [+] Binary mingw32 and mingw64 packages are noarch [+] Spec file contains %{?mingw_debug_package} after the %description section [+] Uses one of the macros %mingw_configure, %mingw_cmake, or %mingw_cmake_kde4 to configure the package [+] Uses the macro %mingw_make to build the package [+] Uses the macro %mingw_make to install the package [/] If package contains translations, the %mingw_find_lang macro must be used [+] No binary package named mingw-$pkgname is generated [+] Libtool .la files are not bundled [+] .def files are not bundled [+] Man pages which duplicate native package are not bundled [+] Info files which duplicate native package are not bundled [+] Provides of the binary mingw32 and mingw64 packages are equal [+] Requires of the binary mingw32 and mingw64 packages are equal The incorrect-fsf-address rpmlint warning should be reported upstream The no-documentation rpmlint warnings in the -static subpackages can be ignored as the documentation is already part of the regular mingw32/mingw64 packages Here are the remaining issues: - Please replace the %{summary} tags with a proper summary specific to the package in question - The 'rm -rf $RPM_BUILD_ROOT' can be removed from the %install section - The %defattr lines in the files sections can also be removed Please fix these minor issues before importing the package in Fedora =============================================== The package mingw-gsl is APPROVED by epienbro =============================================== -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review