[Bug 825415] Review Request: opensmtpd - Free implementation of the server-side SMTP protocol as defined by RFC 5321

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=825415

--- Comment #12 from Matthias Runge <mrunge@xxxxxxxxxxxxxxxxx> ---
Taken from your spec[1]:

%files
%config(noreplace) %{_sysconfdir}/mail/smtpd.conf
%{_bindir}/*
/usr/etc/mail/smtpd.conf
^^^^^^^^^^


What happens, when /etc/mail doesn't exist? Which package owns that dir?
If you meant /etc/mail/smtpd.conf to be placed there, you need to require that
package, which owns /etc/mail (imho currently sendmail)

[1]: http://alvesadrian.fedorapeople.org/opensmtpd.spec

Before we go any further here, you should run something like:

fedora-review -b 825415


You'll get at least:
Issues:
[!]: MUST Package successfully compiles and builds into binary rpms on at
     least one supported primary architecture.
See: http://fedoraproject.org/wiki/Packaging/Guidelines#Architecture_Support
[!]: MUST All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
     Note: The package did not built BR could therefore not be checked or the
     package failed to build because of missing BR
See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
[!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf is only needed if supporting EPEL5


Your package still doesn't compile under mock. I told you in comment #4, you
should test that, you said it does and it turned out there were missing build
requirements. 

I strongly suggest you read the output from fedora-review. If you don't
understand something there, ask!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]