[Bug 827167] Review Request: bumblebee - Bumblebee daemon

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=827167

Brendan Jones <brendan.jones.it@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |brendan.jones.it@xxxxxxxxx

--- Comment #1 from Brendan Jones <brendan.jones.it@xxxxxxxxx> ---
Hi Gary

I'm no sponsor, but I do have this hardware so happy to help out where I can.

You'll need to package VirtualGL first.

A few quick recommendations on the SPEC
 - use macros whereever possible ie. %name.conf %name. for bumblebee
 - drop GNU from the license
 - move the URL from the description to the URL tag e.g.
URL:            http://%{name}-project.org/
 - align all your tags as the previous example for readablity
 - use %{optflags} in place of the CFLAGS you've specified
 - %{sysconfigdir} for /etc %{prefix} for /usr %{_libdir|, %{_bindir} etc
whereerver possible http://fedoraproject.org/wiki/Packaging:RPMMacros
 - create a Source1: for your sysv init script 
 - %clean is only required for EPEL5, similarly rm -rf in %install section, if
you do not intend to build for EPEL5 reomve them 
 - %defattr no longer required

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]