https://bugzilla.redhat.com/show_bug.cgi?id=827136 --- Comment #1 from Andreas Bierfert <andreas.bierfert@xxxxxxxxxxxxx> --- Before the formal review here are some comments of things which must/should be changed: * unnecessary BR: gccmakedep (provided by imake) * never use TM or ™ in summary or description (http://fedoraproject.org/wiki/Packaging/Guidelines#Trademarks_in_Summary_or_Description) * macros should be enclosed with {} (e.g. %{_bindir}) * the source archive contains the asclock source code but does not use to build it. To avoid any confusion and in the best practice of not having bundled software in fedora packages, I would suggest to contact upstream and ask to release a wmclock source w/o the asclock source included. If that is not possible create a stripped source file and add a comment to the spec file. Also see http://fedoraproject.org/wiki/Packaging/SourceURL * if you contact upstream ask if the nopolling patch could be included in the new tarball * the COPYING file must be included as doc (http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text) * consider including the ChangeLog file as doc The rpmlint warnings can be be ignored / do not apply here. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review