[Bug 817622] Re-Review Request: libkgapi - Library to access to Google services

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=817622

--- Comment #3 from Rex Dieter <rdieter@xxxxxxxxxxxx> ---
Initial comments:

1. while you have 
Obsoletes:    libkgoogle < 0.3.2
Provides:    libkgoogle = %{version}-%{release}
you probably ought to do the same for libkgoogle-devel too in the -devel subpkg

2. cosmetics, but
s/%description -n %{name}-devel/%description devel/

3.  These are redundant (already pulled in implicitly via kdelibs-devel), can
be removed:
BuildRequires:    cmake 
BuildRequires:    qt-devel 

4.  %files devel is missing ownership of several dirs, replace
%{_kde4_includedir}/libkgapi/*
...
%{_libdir}/cmake/LibKGAPI/*.cmake
with
%{_kde4_includedir}/libkgapi/
...
%{_libdir}/cmake/LibKGAPI/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]