https://bugzilla.redhat.com/show_bug.cgi?id=824430 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- Source file is original. Ok. Summary verified from lib/Syntax/Feature/Loop.pm. Ok. License verified from lib/Syntax/Feature/Loop.pm and LICENSE. Ok. Description verified from lib/Syntax/Feature/Loop.pm. Ok. XS code presents, BuildArch is Ok. URL and Source0 are usable. Ok. TODO: Build-require `perl(XSLoader)' (lib/Syntax/Feature/Loop.pm:9). TODO: Qualify build-requirement perl(Test::Pod) with `>= 1.22' (t/pod.t:8). The Software::License::CC0_1_0 module is nowhere used. Ok. All tests pass. Ok. $ rpmlint perl-Syntax-Feature-Loop.spec ../SRPMS/perl-Syntax-Feature-Loop-1.6.0-1.fc18.src.rpm ../RPMS/x86_64/perl-Syntax-Feature-Loop-* perl-Syntax-Feature-Loop.src: W: spelling-error %description -l en_US lexically -> lexical, exotically, allergically perl-Syntax-Feature-Loop.src: W: spelling-error %description -l en_US pragma -> pragmatic perl-Syntax-Feature-Loop.x86_64: W: spelling-error %description -l en_US lexically -> lexical, exotically, allergically perl-Syntax-Feature-Loop.x86_64: W: spelling-error %description -l en_US pragma -> pragmatic 3 packages and 1 specfiles checked; 0 errors, 4 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/x86_64/perl-Syntax-Feature-Loop-1.6.0-1.fc18.x86_64.rpm drwxr-xr-x 2 root root 0 May 31 15:26 /usr/lib64/perl5/vendor_perl/Syntax drwxr-xr-x 2 root root 0 May 31 15:26 /usr/lib64/perl5/vendor_perl/Syntax/Feature -rw-r--r-- 1 root root 3320 May 31 15:26 /usr/lib64/perl5/vendor_perl/Syntax/Feature/Loop.pm drwxr-xr-x 2 root root 0 May 31 15:26 /usr/lib64/perl5/vendor_perl/auto/Syntax drwxr-xr-x 2 root root 0 May 31 15:26 /usr/lib64/perl5/vendor_perl/auto/Syntax/Feature drwxr-xr-x 2 root root 0 May 31 15:26 /usr/lib64/perl5/vendor_perl/auto/Syntax/Feature/Loop -rwxr-xr-x 1 root root 6120 May 31 15:26 /usr/lib64/perl5/vendor_perl/auto/Syntax/Feature/Loop/Loop.so drwxr-xr-x 2 root root 0 May 31 15:26 /usr/share/doc/perl-Syntax-Feature-Loop-1.6.0 -rw-r--r-- 1 root root 338 May 19 01:19 /usr/share/doc/perl-Syntax-Feature-Loop-1.6.0/Changes -rw-r--r-- 1 root root 7075 May 19 01:19 /usr/share/doc/perl-Syntax-Feature-Loop-1.6.0/LICENSE -rw-r--r-- 1 root root 1529 May 19 01:19 /usr/share/doc/perl-Syntax-Feature-Loop-1.6.0/README.txt -rw-r--r-- 1 root root 2999 May 31 15:26 /usr/share/man/man3/Syntax::Feature::Loop.3pm.gz File layout and permissions is Ok. $ rpm -q --requires -p ../RPMS/x86_64/perl-Syntax-Feature-Loop-1.6.0-1.fc18.x86_64.rpm |sort |uniq -c 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 perl(Devel::CallParser) 1 perl(Lexical::Sub) 1 perl(:MODULE_COMPAT_5.14.2) 1 perl(strict) 1 perl(syntax) >= 0.004 1 perl(version) 1 perl(warnings) 1 perl(XSLoader) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 1 rtld(GNU_HASH) Binary requires are Ok. $ rpm -q --provides -p ../RPMS/x86_64/perl-Syntax-Feature-Loop-1.6.0-1.fc18.x86_64.rpm |sort |uniq -c 1 perl(Syntax::Feature::Loop) 1 perl-Syntax-Feature-Loop = 1.6.0-1.fc18 1 perl-Syntax-Feature-Loop(x86-64) = 1.6.0-1.fc18 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/x86_64/perl-Syntax-Feature-Loop-1.6.0-1.fc18.x86_64.rpm Binary dependencies resolvable. Ok. Package builds in F18 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4116870). Ok. Package is in line with Fedora and Perl packaging guidelines. Please consider fixing the `TODO' items before building this package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review