https://bugzilla.redhat.com/show_bug.cgi?id=823286 --- Comment #2 from Adrien Devresse <adev88@xxxxxxxxx> --- First comments : -> Compilation failure on Rawhide : + /usr/bin/cmake -DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_INSTALL_PREFIX:PATH=/usr -DINCLUDE_INSTALL_DIR:PATH=/usr/include -DLIB_INSTALL_DIR:PATH=/usr/lib64 -DSYSCONF_INSTALL_DIR:PATH=/etc -DSHARE_INSTALL_PREFIX:PATH=/usr/share -DLIB_SUFFIX=64 -DBUILD_SHARED_LIBS:BOOL=ON . -DCMAKE_INSTALL_PREFIX=/ -- The C compiler identification is GNU 4.7.0 -- The CXX compiler identification is GNU 4.7.0 -- Check for working C compiler: /usr/lib64/ccache/gcc -- Check for working C compiler: /usr/lib64/ccache/gcc -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working CXX compiler: /usr/lib64/ccache/c++ -- Check for working CXX compiler: /usr/lib64/ccache/c++ -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- dpm includes found in /usr/include -- Found dpm: /lib64/libdpm.so -- Found PROTOBUF: /usr/lib64/libprotobuf.so CMake Error at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:97 (MESSAGE): Could NOT find JNI (missing: JAVA_AWT_LIBRARY JAVA_JVM_LIBRARY JAVA_INCLUDE_PATH JAVA_INCLUDE_PATH2 JAVA_AWT_INCLUDE_PATH) Call Stack (most recent call first): /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:288 (_FPHSA_FAILURE_MESSAGE) /usr/share/cmake/Modules/FindJNI.cmake:240 (FIND_PACKAGE_HANDLE_STANDARD_ARGS) tests/CMakeLists.txt:73 (find_package) -- Configuring incomplete, errors occurred! Erreur de construction de RPM : erreur : Mauvais statut de sortie pour /var/tmp/rpm-tmp.ocywBF (%build) Mauvais statut de sortie pour /var/tmp/rpm-tmp.ocywBF (%build) Child return code was: 1 EXCEPTION: Command failed. See logs for output. # ['bash', '--login', '-c', 'rpmbuild -bb --target x86_64 --nodeps builddir/build/SPECS/dmlite.spec'] Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/mockbuild/trace_decorator.py", line 70, in trace result = func(*args, **kw) File "/usr/lib/python2.7/site-packages/mockbuild/util.py", line 352, in do raise mockbuild.exception.Error, ("Command failed. See logs for output.\n # %s" % (command,), child.returncode) Error: Command failed. See logs for output. # ['bash', '--login', '-c', 'rpmbuild -bb --target x86_64 --nodeps builddir/build/SPECS/dmlite.spec'] LEAVE do --> EXCEPTION RAISED -> Why a subversion buildrequires dependency ? Fetching file at build time in a src.rpm is forbidden by the Fedora packaging policy. -> ISA macro is not needed by the BuildRequires field, only by the Requires fields. -> Requires: mysql -> has a missing ISA macro -> %package libs, Summary: Libraries -> Could it have a more explicit summary with the component name ? -> It is better for readability to use %-style variables pr $-style variables, but not mixing both -> I see a cppunit-devel a dependency but no %check section for Unit test execution. -> %{_mandir} macro and %{_docdir} macro could be used. -> It is better to avoid %cmake macro overloading when possible : -DCMAKE_INSTALL_PREFIX=/ -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review