https://bugzilla.redhat.com/show_bug.cgi?id=812587 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #6 from Petr Pisar <ppisar@xxxxxxxxxx> --- Spec file changes: --- perl-FusionInventory-Agent-Task-Deploy.spec.old 2012-05-29 07:05:23.025998958 -0400 +++ perl-FusionInventory-Agent-Task-Deploy.spec 2012-05-31 03:55:12.122006698 -0400 @@ -1,6 +1,6 @@ Name: perl-FusionInventory-Agent-Task-Deploy Version: 2.0.0 -Release: 2%{?dist} +Release: 3%{?dist} Summary: Software deployment support for FusionInventory Agent License: GPLv2+ Group: Development/Libraries @@ -10,24 +10,38 @@ BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) BuildArch: noarch BuildRequires: perl >= 1:5.8.0 +BuildRequires: perl(base) BuildRequires: perl(inc::Module::Install) BuildRequires: perl(Archive::Extract) BuildRequires: perl(Archive::Tar) +BuildRequires: perl(Compress::Zlib) +BuildRequires: perl(Cwd) +BuildRequires: perl(Data::Dumper) BuildRequires: perl(Digest::SHA) +BuildRequires: perl(Exporter) BuildRequires: perl(File::Copy::Recursive) +BuildRequires: perl(File::Path) +BuildRequires: perl(File::Spec) +BuildRequires: perl(File::Which) +BuildRequires: perl(HTTP::Request) +BuildRequires: perl(HTTP::Request::Common) +BuildRequires: perl(HTTP::Server::Simple::CGI) BuildRequires: perl(JSON) +BuildRequires: perl(LWP) +BuildRequires: perl(Net::IP) +BuildRequires: perl(POE) BuildRequires: perl(POE::Component::Client::Ping) +BuildRequires: perl(POE::Component::Client::TCP) BuildRequires: perl(Test::Compile) BuildRequires: perl(Test::HTTP::Server::Simple) +BuildRequires: perl(Test::More) +BuildRequires: perl(UNIVERSAL::require) BuildRequires: perl(URI::Escape) BuildRequires: fusioninventory-agent >= 2.2.0 -%if 0%{?fedora} >= 14 -BuildRequires: perl(HTTP::Server::Simple::Authen) perl(CGI) -%endif Requires: fusioninventory-agent >= 2.2.0 -Requires: perl(Digest::SHA) Requires: perl(POE::Component::Client::Ping) +Requires: perl(POE::Component::Client::TCP) Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) # RPM 4.8 @@ -88,6 +102,9 @@ %changelog +* Wed May 30 2012 Remi Collet <remi@xxxxxxxxxxxxxxxxx> - 2.0.0-3 +- fix BuildRequires/Requires from review #812587 + * Fri May 11 2012 Remi Collet <remi@xxxxxxxxxxxxxxxxx> - 2.0.0-2 - filter private provides/requires > FIX: Build- and run-require `perl(POE::Component::Client::TCP)' > (lib/FusionInventory/Agent/Task/Deploy/P2P.pm:9). +BuildRequires: perl(POE::Component::Client::TCP) +Requires: perl(POE::Component::Client::TCP) Ok. > FIX: Build-require `perl(File::Which)' (Makefile.PL:13). +BuildRequires: perl(File::Which) Ok. > TODO: Build-require `perl(base)' (lib/FusionInventory/Agent/Task/Deploy.pm:8). +BuildRequires: perl(base) Ok. > FIX: Build-require `perl(LWP)' (lib/FusionInventory/Agent/Task/Deploy.pm:11). +BuildRequires: perl(LWP) Ok. > FIX: Build-require `perl(Compress::Zlib)' (lib/FusionInventory/Agent/Task/Deploy/Datastore/WorkDir.pm:7). +BuildRequires: perl(Compress::Zlib) Ok. > TODO: Build-require `perl(Exporter)' (lib/FusionInventory/Agent/Task/Deploy/DiskFree.pm:5). +BuildRequires: perl(Exporter) Ok. > FIX: Build-require `perl(UNIVERSAL::require)' (lib/FusionInventory/Agent/Task/Deploy/DiskFree.pm:10). +BuildRequires: perl(UNIVERSAL::require) Ok. > FIX: Build-require `perl(File::Spec)' (lib/FusionInventory/Agent/Task/Deploy/Datastore.pm:8). +BuildRequires: perl(File::Spec) Ok. > FIX: Build-require `perl(HTTP::Request::Common)' (lib/FusionInventory/Agent/Task/Deploy/P2P.pm:7). +BuildRequires: perl(HTTP::Request::Common) Ok. > FIX: Build-require `perl(Net::IP)' (lib/FusionInventory/Agent/Task/Deploy/P2P.pm:8). +BuildRequires: perl(Net::IP) Ok. > FIX: Build-require `perl(POE)' (lib/FusionInventory/Agent/Task/Deploy/P2P.pm:9). +BuildRequires: perl(POE) Ok. > FIX: Build-require `perl(Cwd)' > (lib/FusionInventory/Agent/Task/Deploy/ActionProcessor.pm:6). +BuildRequires: perl(Cwd) Ok. > FIX: Build-require `perl(HTTP::Request)' > (lib/FusionInventory/Agent/Task/Deploy/File.pm:10). +BuildRequires: perl(HTTP::Request) Ok. > FIX: Build-require `perl(Test::More)' (t/06spelling.t:6). +BuildRequires: perl(Test::More) Ok. > FIX: Build-require `perl(HTTP::Server::Simple::CGI)' (t/server.t:7). +BuildRequires: perl(HTTP::Server::Simple::CGI) > FIX: Build-require `perl(Data::Dumper)' (t/server.t:12). +BuildRequires: perl(Data::Dumper) Ok. > > TODO: You can remove the BuildRoot tag and it's cleaning if your are not > > intent to build this package in EPEL-5. The actions are implicit in newer > > distributions. > > TODO: Remove the %defattr from %files section. This is implicit in all > > distributions. > (I still prefer to keep old stuff, builroot, defattr, clean, ... until RHEL-5 > EOL) Ok. $ rpmlint perl-FusionInventory-Agent-Task-Deploy.spec ../SRPMS/perl-FusionInventory-Agent-Task-Deploy-2.0.0-3.fc18.src.rpm ../RPMS/noarch/perl-FusionInventory-Agent-Task-Deploy-2.0.0-3.fc18.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. > TODO: Do not run-require `perl(Digest::SHA)' explicitly. It's auto-detected. > FIX: Run-require `perl(POE::Component::Client::TCP)' > (lib/FusionInventory/Agent/Task/Deploy/P2P.pm:9). $ rpm -q --requires -p ../RPMS/noarch/perl-FusionInventory-Agent-Task-Deploy-2.0.0-3.fc18.noarch.rpm |sort |uniq -c 1 fusioninventory-agent >= 2.2.0 1 perl(Archive::Extract) 1 perl(base) 1 perl(Compress::Zlib) 1 perl(Cwd) 1 perl(Digest::SHA) 1 perl(English) 1 perl(Exporter) 1 perl(File::Basename) 1 perl(File::Copy::Recursive) 1 perl(File::Glob) 1 perl(File::Path) 1 perl(File::Spec) 1 perl(HTTP::Request) 1 perl(HTTP::Request::Common) 1 perl(JSON) 1 perl(LWP) 1 perl(:MODULE_COMPAT_5.14.2) 1 perl(Net::IP) 1 perl(POE) 1 perl(POE::Component::Client::Ping) 1 perl(POE::Component::Client::TCP) 1 perl(strict) 1 perl(UNIVERSAL::require) 1 perl(URI::Escape) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-FusionInventory-Agent-Task-Deploy-2.0.0-3.fc18.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F18 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4116264). Ok. Package is in line with Fedora and Perl packaging guidelines. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review