[Bug 807472] Review Request: libstoragemgmt - Library for storage array management

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=807472

--- Comment #7 from Tony Asleson <tasleson@xxxxxxxxxx> ---
(In reply to comment #6)
> A few things:
> 
> * You need BuildRequires: systemd-units for %{_unitdir} to evaluate.

Done

> * You're enabling this service by default, which is almost certainly not
> appropriate. You're also not using the proper scriptlets for systemd. See:
> https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd

The library service does not require configuration and does not provide network
services, thus it meets the criteria to be enabled by default
(https://fedoraproject.org/wiki/Starting_services_by_default).  I did remove
the service starts.

> Correct those items, and I will do a review.

Great, thank you!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]