[Bug 825333] Review Request: libopkele - A C++ implementation of the OpenID decentralized identity system

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=825333

--- Comment #2 from Michael Schwendt <mschwendt@xxxxxxxxx> ---
> Requires:       %{name} = %{version}-%{release}

https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package


> Summary:        A C++ implementation of the OpenID decentralized identity system

Some day we will have eliminated all remaining leading articles from package
summaries. ;)
Sure, it's a matter of taste, but summaries are even more concise, if they
don't start with superfluous "A", "An, "The".


> http://koji.fedoraproject.org/koji/getfile?taskID=4101114&name=build.log
> ...
> checking for UUID... no

Smells like "BuildRequires: libuuid-devel" is missing.


> $ cat libopkele.pc 
> ...
> Requires: openssl
> Libs: -L${libdir} -lopkele -lcurl   -lexpat -ltidy

These explicitly linked libs deserve a closer look. First of all, they mean
that libopkele-devel is missing "Requires: libcurl-devel libdidy-devel
expat-devel" because no automatic pkg-config dep is present. Secondly, only
"curl" headers are included from within libopkele headers, so there is no need
to (re)link with the other two libs.


> libopkele-2.0.4/test/

The "test" executable that is built by default looks like it could be executed
in a %check section.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]