https://bugzilla.redhat.com/show_bug.cgi?id=825557 Erik van Pienbroek <erik-fedora@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |erik-fedora@xxxxxxxxxxxxxxx --- Comment #2 from Erik van Pienbroek <erik-fedora@xxxxxxxxxxxxxxx> --- The new approved MinGW packaging guidelines can be found at https://fedoraproject.org/wiki/PackagingDrafts/MinGWCrossCompiler Some initial review comments: - Please change %?mingw_package_header to %{?mingw_package_header} - Please remove the use of the _cross_pkg_name global - Please add BuildRequires: mingw32-filesystem >= 95 and BuildRequires: mingw64-filesystem >= 95 - Why are the binary packages named mingw32-clucene-core and mingw-64-clucene-core instead of just mingw32-clucene and mingw64-clucene? - Please replace the %{description} tags with the complete description. Last time I used this tag it didn't produce the expected result - Why is multithreading disabled? - Why do you set the CFLAGS _CL_HAVE_WIN32_THREADS=0 ? Is support for win32 threads disabled by this? - Why is LUCENE_STATIC_CONSTANT_SYNTAX_EXITCODE set to 1 and the other defines to 0? - The 'rm -rf $RPM_BUILD_ROOT' can be removed from the %install section as it's not needed any more - The quotes used in %mingw_make call aren't needed any more and can be removed - The %defattr tags aren't needed any more with modern RPM and can also be removed I'm not a Fedora sponsor, so I can't formally approve this package. rwmjones: would you be interested in sponsoring Greg? -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review