https://bugzilla.redhat.com/show_bug.cgi?id=817847 --- Comment #3 from Fabian Affolter <mail@xxxxxxxxxxxxxxxxxx> --- Thanks Michal. (In reply to comment #2) > Review Summary: > - biggest issue is the licensing. Software seems to be licensed with 3 > clause > BSD style license while rpm package is told to be GPLv2+ - please fix GPLv2+ is wrong, changed. > - upstream package doesn't contain soem overall separate file with a license > - > please could you contact the upstream to evaluate possibility to add one? I asked upstream to include a COPYING file. > - %files section contains %defattr. This is probably needed only for packages > or EL5 - do you plan to build package for EL5? > See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions Leftover, removed Updated files: Spec URL: http://fab.fedorapeople.org/packages/SRPMS/kismon.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/kismon-0.5-2.fc16.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review